Skip to content

7904181: JMH: Fix xctrace samples handling for Xcode 26.4+#174

Open
fzhinkin wants to merge 1 commit into
openjdk:masterfrom
fzhinkin:master
Open

7904181: JMH: Fix xctrace samples handling for Xcode 26.4+#174
fzhinkin wants to merge 1 commit into
openjdk:masterfrom
fzhinkin:master

Conversation

@fzhinkin
Copy link
Copy Markdown
Contributor

@fzhinkin fzhinkin commented May 22, 2026 •
edited by openjdk Bot
Loading

xctrace's XML trace schema had changed slightly starting from Xcode 26.4.

Before, every stacktrace will be represented by the <backtrace/> element with multiple <frame/> elements inside.
Starting from Xcode 26.4, the stracktrace is nested into the <tagged-backtrace/> element.

Even though tagged-backtrace does not provide any additional information that could be used by the XCTraceAsmProfiler, it uses the same trick with including an element with the full content and a unique id only once and referencing it by the id. As a result, it has to handled the same way any other "valuable" elements are handled.

This PR supports the new tagged-backtrace tag.

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/174/head:pull/174
$ git checkout pull/174

Update a local copy of the PR:
$ git checkout pull/174
$ git pull https://git.openjdk.org/jmh.git pull/174/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 174

View PR using the GUI difftool:
$ git pr show -t 174

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/174.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 22, 2026

👋 Welcome back fzhinkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 22, 2026 •
edited
Loading

@fzhinkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7904181: JMH: Fix xctrace samples handling for Xcode 26.4+

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 22, 2026

⚠️ @fzhinkin a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 996afd57d025544adefe727ca32e09d18017a72e
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 23, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 23, 2026

Webrevs

shipilev
shipilev approved these changes May 29, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, thanks!

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shipilev shipilev shipilev approved these changes

Assignees

No one assigned

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fzhinkin @shipilev